Kuninori Morimoto
dec6aa49ab
fbdev: sh_mobile_hdmi: modify flags name to more specific
This patch solve below report from Guennadi
1)
> +/* Audio source select */
> +#define HDMI_SRC_MASK (0xF << 0)
> +#define HDMI_SRC_I2S (0 << 0) /* default */
> +#define HDMI_SRC_SPDIF (1 << 0)
> +#define HDMI_SRC_DSD (2 << 0)
> +#define HDMI_SRC_HBR (3 << 0)
I would be more specific with these macro names, i.e., include "AUDIO" or
"SND" or something similar in them, e.g., HDMI_AUDIO_SRC_I2S.
2)
> + case HDMI_SRC_I2S:
> + data = (0x0 << 3);
> + break;
> + case HDMI_SRC_SPDIF:
> + data = (0x1 << 3);
> + break;
> + case HDMI_SRC_DSD:
> + data = (0x2 << 3);
> + break;
> + case HDMI_SRC_HBR:
> + data = (0x3 << 3);
In all above cases parenthesis are superfluous.
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
2010-09-10 16:07:41 +01:00
..
2009-04-01 08:59:26 -07:00
2010-03-12 15:52:34 -08:00
2009-04-01 08:59:27 -07:00
2010-05-25 08:07:09 -07:00
2010-08-14 22:26:51 +02:00
2009-02-05 12:56:48 -08:00
2010-05-24 08:47:38 +09:00
2009-04-01 08:59:31 -07:00
2009-12-01 09:02:32 +08:00
2009-04-01 08:59:26 -07:00
2009-06-16 19:48:00 -07:00
2009-12-04 15:39:52 +01:00
2010-05-24 08:49:05 +09:00
2010-09-10 16:07:41 +01:00
2010-08-04 16:12:11 +09:00
2009-01-31 00:14:28 +05:30
2009-04-07 08:31:08 -07:00
2009-01-31 00:14:52 +05:30