Jiaying Zhang dccaf33fa3
ext4: flush any pending end_io requests before DIO reads w/dioread_nolock ...
There is a race between ext4 buffer write and direct_IO read with
dioread_nolock mount option enabled. The problem is that we clear
PageWriteback flag during end_io time but will do
uninitialized-to-initialized extent conversion later with dioread_nolock.
If an O_direct read request comes in during this period, ext4 will return
zero instead of the recently written data.
This patch checks whether there are any pending uninitialized-to-initialized
extent conversion requests before doing O_direct read to close the race.
Note that this is just a bandaid fix. The fundamental issue is that we
clear PageWriteback flag before we really complete an IO, which is
problem-prone. To fix the fundamental issue, we may need to implement an
extent tree cache that we can use to look up pending to-be-converted extents.
Signed-off-by: Jiaying Zhang <jiayingz@google.com >
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu >
Cc: stable@kernel.org
2011-08-19 19:13:32 -04:00
2011-08-01 02:10:06 -04:00
2011-07-20 20:47:59 -04:00
2011-07-20 20:48:03 -04:00
2011-05-30 01:50:53 -04:00
2011-05-28 01:02:50 -04:00
2011-08-02 21:14:05 -10:00
2011-07-20 01:44:21 -04:00
2011-07-26 13:38:50 -07:00
2011-08-05 15:03:09 +00:00
2011-07-20 20:47:59 -04:00
2011-05-28 01:02:54 -04:00
2011-07-17 23:22:02 -04:00
2011-05-19 16:55:28 +09:30
2011-07-25 22:49:19 -07:00
2011-07-28 23:48:26 -05:00
2011-07-20 01:44:26 -04:00
2011-08-06 22:56:03 -07:00
2011-08-01 13:48:31 -10:00
2011-08-01 02:10:06 -04:00
2011-08-19 19:13:32 -04:00
2011-07-20 20:47:59 -04:00
2011-07-21 10:59:16 -07:00
2011-07-25 22:49:19 -07:00
2011-08-01 13:48:31 -10:00
2011-07-20 20:47:59 -04:00
2011-07-22 19:02:39 -07:00
2011-07-20 20:47:59 -04:00
2011-07-20 20:47:59 -04:00
2011-07-27 22:21:58 -04:00
2011-07-25 21:00:19 -07:00
2011-07-22 19:42:12 -04:00
2011-06-28 00:06:41 +02:00
2011-07-10 22:05:08 -04:00
2011-08-01 02:10:06 -04:00
2011-08-01 13:48:31 -10:00
2011-07-27 13:23:02 -07:00
2011-07-20 20:47:59 -04:00
2011-07-20 20:47:53 -04:00
2011-07-20 20:47:59 -04:00
2011-08-01 13:48:31 -10:00
2011-07-25 22:49:19 -07:00
2011-07-20 20:47:59 -04:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-08-01 02:10:06 -04:00
2011-07-26 13:05:28 -04:00
2011-07-01 16:17:13 +02:00
2011-08-06 11:51:33 -07:00
2011-07-22 16:14:39 -07:00
2011-05-25 08:39:26 -07:00
2011-08-01 02:10:06 -04:00
2011-06-27 18:00:12 -07:00
2011-07-25 22:50:35 -07:00
2011-07-20 01:43:24 -04:00
2011-05-28 01:02:50 -04:00
2011-07-22 19:02:39 -07:00
2011-07-20 01:43:07 -04:00
2011-07-20 01:44:26 -04:00
2011-08-01 13:48:31 -10:00
2011-07-26 12:57:09 -04:00
2011-07-20 20:47:47 -04:00
2011-07-20 20:47:59 -04:00
2011-07-20 01:43:10 -04:00
2011-07-20 01:43:10 -04:00
2011-07-20 01:43:10 -04:00
2011-05-28 14:44:46 +02:00
2011-08-01 21:33:47 -04:00
2011-06-16 11:44:46 -04:00
2011-07-01 22:32:26 +02:00
2011-07-15 18:58:42 -04:00
2011-08-06 22:52:40 -07:00
2011-05-31 16:33:35 +02:00
2011-07-26 16:49:47 -07:00
2011-05-25 08:39:26 -07:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:44 -07:00
2011-07-26 16:49:47 -07:00
2011-07-31 22:52:08 +08:00
2011-08-01 02:10:06 -04:00
2011-08-06 22:53:23 -07:00
2011-07-20 01:44:38 -04:00
2011-08-03 14:25:25 -10:00
2011-07-22 19:42:11 -04:00
2011-07-20 20:23:19 -04:00
2011-07-15 18:58:42 -04:00
2011-05-25 08:39:26 -07:00
2011-05-26 10:01:43 -06:00
2011-08-07 13:42:25 -07:00
2011-07-24 10:08:32 -04:00
2011-07-26 15:07:43 -04:00
2011-07-26 12:57:09 -04:00
2011-08-01 02:10:32 -04:00
2011-07-26 12:57:09 -04:00
2011-07-25 20:57:11 -07:00
2011-08-03 14:25:24 -10:00
2011-08-06 22:53:23 -07:00
2011-07-25 10:33:36 -07:00
2011-07-20 20:47:59 -04:00
2011-06-14 11:46:14 +02:00
2011-05-28 12:02:09 -04:00
dccaf33fa3