Stanislaw Gruszka
674db13444
rt2x00: fix crash in rt2800usb_get_txwi
Patch should fix this oops:
BUG: unable to handle kernel NULL pointer dereference at 000000a0
IP: [<f81b30c9>] rt2800usb_get_txwi+0x19/0x70 [rt2800usb]
*pdpt = 0000000000000000 *pde = f000ff53f000ff53
Oops: 0000 [#1] SMP
Pid: 198, comm: kworker/u:3 Tainted: G W 3.0.0-wl+ #9 LENOVO 6369CTO/6369CTO
EIP: 0060:[<f81b30c9>] EFLAGS: 00010283 CPU: 1
EIP is at rt2800usb_get_txwi+0x19/0x70 [rt2800usb]
EAX: 00000000 EBX: f465e140 ECX: f4494960 EDX: ef24c5f8
ESI: 810f21f5 EDI: f1da9960 EBP: f4581e80 ESP: f4581e70
DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
Process kworker/u:3 (pid: 198, ti=f4580000 task=f4494960 task.ti=f4580000)
Call Trace:
[<f804790f>] rt2800_txdone_entry+0x2f/0xf0 [rt2800lib]
[<c045110d>] ? warn_slowpath_common+0x7d/0xa0
[<f81b3a38>] ? rt2800usb_work_txdone+0x288/0x360 [rt2800usb]
[<f81b3a38>] ? rt2800usb_work_txdone+0x288/0x360 [rt2800usb]
[<f81b3a13>] rt2800usb_work_txdone+0x263/0x360 [rt2800usb]
[<c046a8d6>] process_one_work+0x186/0x440
[<c046a85a>] ? process_one_work+0x10a/0x440
[<f81b37b0>] ? rt2800usb_probe_hw+0x120/0x120 [rt2800usb]
[<c046c283>] worker_thread+0x133/0x310
[<c04885db>] ? trace_hardirqs_on+0xb/0x10
[<c046c150>] ? manage_workers+0x1e0/0x1e0
[<c047054c>] kthread+0x7c/0x90
[<c04704d0>] ? __init_kthread_worker+0x60/0x60
[<c0826b42>] kernel_thread_helper+0x6/0x1
Oops might happen because we check rt2x00queue_empty(queue) twice,
but this condition can change and we can process entry in
rt2800_txdone_entry(), which was already processed by
rt2800usb_txdone_entry_check() -> rt2x00lib_txdone_noinfo() and
has nullify entry->skb .
Reported-by: Justin Piszcz <jpiszcz@lucidpixels.com>
Cc: stable@kernel.org
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2011-08-11 14:34:37 -04:00
..
2011-06-21 15:48:29 -07:00
2011-06-30 22:13:38 -07:00
2011-07-21 13:47:54 -07:00
2011-07-21 13:47:54 -07:00
2011-07-26 16:49:47 -07:00
2011-07-21 21:32:54 -07:00
2011-07-23 20:01:15 -07:00
2011-07-24 13:11:40 -07:00
2011-07-27 22:39:30 -07:00
2011-07-07 00:26:31 -07:00
2011-07-25 13:56:39 -07:00
2011-07-21 13:47:54 -07:00
2011-07-26 16:49:47 -07:00
2011-07-26 16:49:47 -07:00
2011-07-21 13:47:54 -07:00
2011-07-21 22:53:41 -07:00
2011-07-12 22:07:56 -07:00
2011-07-21 13:47:53 -07:00
2011-07-21 13:47:55 -07:00
2011-07-25 13:56:39 -07:00
2011-07-26 16:49:47 -07:00
2011-07-23 20:01:15 -07:00
2011-07-21 13:47:55 -07:00
2011-07-25 13:56:39 -07:00
2011-07-21 22:57:38 -07:00
2011-07-21 13:47:56 -07:00
2011-07-22 14:50:12 -07:00
2011-06-29 06:02:05 -07:00
2011-07-21 21:32:54 -07:00
2011-07-26 16:49:47 -07:00
2011-07-21 13:47:57 -07:00
2011-07-23 20:01:15 -07:00
2011-07-14 08:43:32 -07:00
2011-07-21 15:29:16 -07:00
2011-06-21 15:48:29 -07:00
2011-07-21 13:38:42 -07:00
2011-07-27 22:39:31 -07:00
2011-07-21 20:39:47 -07:00
2011-07-21 13:47:57 -07:00
2011-07-27 22:39:30 -07:00
2011-07-26 16:49:47 -07:00
2011-08-11 14:34:37 -04:00
2011-06-30 11:19:09 -07:00
2011-06-20 22:29:08 -07:00
2011-07-08 09:03:20 -07:00
2011-07-15 08:08:26 -07:00
2011-07-05 23:23:37 -07:00
2011-07-08 09:03:20 -07:00
2011-07-25 16:16:00 -07:00
2011-07-25 16:16:00 -07:00
2011-07-21 13:47:54 -07:00
2011-07-21 13:47:54 -07:00
2011-06-24 17:31:36 -07:00
2011-07-25 13:56:39 -07:00
2011-07-25 13:56:39 -07:00
2011-07-08 09:03:20 -07:00
2011-07-21 12:38:32 -07:00
2011-07-14 08:46:08 -07:00
2011-07-21 14:10:00 +02:00
2011-07-26 16:49:47 -07:00
2011-07-21 12:38:32 -07:00
2011-07-21 12:38:32 -07:00
2011-06-21 16:06:11 -07:00
2011-07-26 16:49:47 -07:00
2011-06-21 15:48:29 -07:00
2011-07-25 13:56:39 -07:00
2011-07-08 09:03:20 -07:00
2011-07-04 20:27:29 -07:00
2011-06-21 15:48:29 -07:00
2011-06-24 11:20:14 +02:00
2011-06-21 15:48:29 -07:00
2011-07-25 13:56:39 -07:00
2011-07-08 09:03:20 -07:00
2011-06-21 15:48:29 -07:00
2011-07-25 13:56:39 -07:00
2011-07-08 09:03:20 -07:00
2011-07-27 22:39:30 -07:00
2011-07-21 13:47:55 -07:00
2011-07-27 22:39:30 -07:00
2011-07-21 13:47:55 -07:00
2011-07-05 23:23:37 -07:00
2011-06-21 15:48:29 -07:00
2011-07-08 09:03:20 -07:00
2011-07-26 16:49:47 -07:00
2011-07-27 22:39:30 -07:00
2011-07-08 09:03:20 -07:00
2011-07-04 20:27:29 -07:00
2011-07-21 20:21:27 -07:00
2011-07-21 13:47:55 -07:00
2011-07-16 12:35:27 -07:00
2011-07-08 09:03:20 -07:00
2011-07-08 09:03:20 -07:00
2011-07-08 09:03:20 -07:00
2011-06-24 17:31:37 -07:00
2011-06-29 02:55:59 -07:00
2011-07-25 13:56:39 -07:00
2011-06-21 15:48:29 -07:00
2011-07-27 22:39:30 -07:00
2011-07-07 04:41:24 -07:00
2011-07-27 22:39:31 -07:00
2011-07-25 13:56:39 -07:00
2011-07-25 13:56:39 -07:00
2011-06-27 21:40:45 -07:00
2011-07-21 13:47:56 -07:00
2011-07-08 09:03:20 -07:00
2011-07-13 02:29:59 -07:00
2011-06-20 22:29:08 -07:00
2011-06-29 05:48:41 -07:00
2011-07-26 16:49:47 -07:00
2011-07-18 11:48:28 -07:00
2011-06-24 02:40:08 -07:00
2011-07-14 16:03:29 -07:00
2011-07-14 16:03:29 -07:00
2011-07-25 13:56:39 -07:00
2011-06-21 15:48:29 -07:00
2011-07-21 13:38:42 -07:00
2011-07-25 13:56:39 -07:00
2011-07-05 23:23:37 -07:00
2011-07-21 13:47:55 -07:00
2011-07-25 13:56:39 -07:00
2011-06-21 19:17:20 -07:00
2011-07-14 07:56:40 -07:00
2011-06-21 15:48:29 -07:00
2011-07-07 00:30:09 -07:00
2011-07-08 08:53:33 -07:00
2011-07-08 08:53:33 -07:00
2011-07-19 16:55:42 -07:00
2011-07-19 16:55:42 -07:00
2011-07-08 09:03:20 -07:00
2011-07-08 09:03:20 -07:00
2011-07-08 09:03:20 -07:00
2011-06-20 13:56:54 -07:00
2011-06-19 16:35:31 -07:00
2011-07-21 13:47:55 -07:00
2011-07-21 13:47:56 -07:00
2011-07-08 09:03:20 -07:00
2011-07-25 13:56:39 -07:00
2011-07-08 09:03:20 -07:00
2011-07-08 09:03:20 -07:00
2011-07-08 09:03:20 -07:00
2011-07-21 13:47:55 -07:00
2011-07-21 13:47:55 -07:00
2011-07-27 22:39:32 -07:00
2011-07-27 22:39:32 -07:00
2011-07-27 22:39:30 -07:00
2011-06-21 15:48:29 -07:00
2011-06-30 22:32:49 -07:00
2011-07-27 22:39:30 -07:00
2011-07-23 20:01:16 -07:00
2011-07-21 13:47:56 -07:00
2011-07-21 21:29:34 -07:00
2011-06-21 15:57:05 -07:00
2011-06-21 15:48:29 -07:00
2011-06-21 15:48:29 -07:00
2011-06-24 17:31:37 -07:00