1
0
Files
linux/fs
J. Bruce Fields 7447758be7 nfsd4: clarify that renewing expired client is a bug
This can't happen:
	- cl_time is zeroed only by unhash_client_locked, which is only
	  ever called under both the state lock and the client lock.
	- every caller of renew_client() should have looked up a
	  (non-expired) client and then called renew_client() all
	  without dropping the state lock.
	- the only other caller of renew_client_locked() is
	  release_session_client(), which first checks under the
	  client_lock that the cl_time is nonzero.

So make it clear that this is a bug, not something we handle.  I can't
quite bring myself to make this a BUG(), though, as there are a lot of
renew_client() callers, and returning here is probably safer than a
BUG().

We'll consider making it a BUG() after some more cleanup.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
2012-05-31 20:30:14 -04:00
..
2012-04-03 20:46:09 -05:00
2012-03-31 16:03:16 -04:00
2012-03-20 21:29:52 -04:00
2012-03-20 21:29:38 -04:00
2012-03-20 21:29:46 -04:00
2012-03-20 21:29:46 -04:00
2012-03-20 21:29:51 -04:00
2012-04-05 15:25:50 -07:00
2012-03-20 21:29:38 -04:00