J. Bruce Fields
7447758be7
nfsd4: clarify that renewing expired client is a bug
...
This can't happen:
- cl_time is zeroed only by unhash_client_locked, which is only
ever called under both the state lock and the client lock.
- every caller of renew_client() should have looked up a
(non-expired) client and then called renew_client() all
without dropping the state lock.
- the only other caller of renew_client_locked() is
release_session_client(), which first checks under the
client_lock that the cl_time is nonzero.
So make it clear that this is a bug, not something we handle. I can't
quite bring myself to make this a BUG(), though, as there are a lot of
renew_client() callers, and returning here is probably safer than a
BUG().
We'll consider making it a BUG() after some more cleanup.
Signed-off-by: J. Bruce Fields <bfields@redhat.com >
2012-05-31 20:30:14 -04:00
..
2012-03-28 09:58:38 -07:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-03-21 13:36:41 -07:00
2012-03-29 18:12:23 -07:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-03-30 12:44:29 -07:00
2012-03-20 21:29:41 -04:00
2012-03-28 10:01:29 -07:00
2012-04-03 20:46:09 -05:00
2012-03-28 18:30:03 +01:00
2012-03-20 21:29:48 -04:00
2012-03-21 13:36:41 -07:00
2012-04-05 15:25:50 -07:00
2012-03-21 13:36:41 -07:00
2012-04-05 15:25:50 -07:00
2012-03-20 21:29:49 -04:00
2012-03-20 21:29:35 -04:00
2012-03-28 20:04:27 -07:00
2012-03-31 16:03:16 -04:00
2012-03-31 16:03:16 -04:00
2012-03-29 17:00:56 -07:00
2012-03-23 16:58:40 -07:00
2012-03-20 21:29:35 -04:00
2012-03-21 13:36:41 -07:00
2012-03-31 16:03:15 -04:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:53 -04:00
2012-03-27 18:29:53 -07:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-04-05 15:25:50 -07:00
2012-03-20 21:29:35 -04:00
2012-03-21 10:15:51 -07:00
2012-03-28 15:58:21 -07:00
2012-03-30 17:31:56 -07:00
2012-03-20 21:29:48 -04:00
2012-05-31 20:29:44 -04:00
2012-03-21 13:36:41 -07:00
2012-03-21 13:36:41 -07:00
2012-03-28 18:30:03 +01:00
2012-05-31 20:29:55 -04:00
2012-05-31 20:30:14 -04:00
2012-03-21 13:36:41 -07:00
2012-03-23 16:58:31 -07:00
2012-03-21 13:36:41 -07:00
2012-03-31 16:03:15 -04:00
2012-03-20 21:29:35 -04:00
2012-03-20 21:29:35 -04:00
2012-04-05 15:30:34 -07:00
2012-04-05 15:30:34 -07:00
2012-03-20 21:29:52 -04:00
2012-03-20 21:29:38 -04:00
2012-03-28 10:00:14 -07:00
2012-03-20 21:29:37 -04:00
2012-03-28 15:58:21 -07:00
2012-03-30 17:31:56 -07:00
2012-03-28 18:05:54 -07:00
2012-03-21 13:36:41 -07:00
2012-03-20 21:29:35 -04:00
2012-03-23 09:27:40 -07:00
2012-03-28 10:00:14 -07:00
2012-03-28 18:30:03 +01:00
2012-03-28 15:58:21 -07:00
2012-03-31 16:03:15 -04:00
2012-03-20 21:29:45 -04:00
2012-02-28 19:31:58 -05:00
2012-02-28 19:31:58 -05:00
2012-03-28 18:30:03 +01:00
2012-03-28 18:30:03 +01:00
2012-03-29 18:12:23 -07:00
2012-03-20 21:29:46 -04:00
2012-03-28 15:58:21 -07:00
2012-03-23 16:58:31 -07:00
2012-03-20 21:29:46 -04:00
2012-03-20 21:29:51 -04:00
2012-03-20 21:48:21 +08:00
2012-02-28 19:31:58 -05:00
2012-03-23 16:58:31 -07:00
2012-03-28 17:14:35 -07:00
2012-03-24 10:24:31 -07:00
2012-03-29 18:12:23 -07:00
2012-03-28 09:54:34 -07:00
2012-02-28 19:31:58 -05:00
2012-02-23 15:56:21 -08:00
2012-02-28 19:31:58 -05:00
2012-03-28 15:58:21 -07:00
2012-04-04 10:04:42 -07:00
2012-02-19 10:30:52 -08:00
2012-03-20 21:29:32 -04:00
2012-03-29 18:12:23 -07:00
2012-03-24 10:24:31 -07:00
2012-03-28 10:07:27 -07:00
2012-03-20 21:29:51 -04:00
2012-02-28 19:31:58 -05:00
2012-02-07 07:51:30 +01:00
2012-03-21 13:36:41 -07:00
2012-01-10 16:30:51 -08:00
2012-04-05 15:25:50 -07:00
2012-04-01 13:54:27 -05:00
2012-03-20 21:29:38 -04:00
2012-02-28 19:31:58 -05:00
2012-04-06 13:54:56 -07:00
2012-01-08 13:21:22 -08:00
2012-02-19 10:30:52 -08:00
2012-03-23 16:58:31 -07:00
2012-02-28 19:31:58 -05:00
2012-02-28 19:31:58 -05:00
2012-02-28 19:31:58 -05:00
2012-03-29 18:12:23 -07:00
2012-03-24 10:24:31 -07:00
2012-02-24 11:42:50 -08:00
2012-04-05 19:04:27 -04:00
2012-02-28 19:31:58 -05:00
2012-03-24 10:24:31 -07:00
2012-02-28 19:31:58 -05:00
2012-03-24 10:24:31 -07:00
2012-02-28 19:31:58 -05:00
2012-02-28 19:31:58 -05:00
2012-04-05 15:25:50 -07:00