sugar/linux
1
0
Fork 0
Code Activity

scsi: ufs: core: Simplify ufshcd_mcq_sq_cleanup() using guard()

Browse Source 
Simplify ufshcd_mcq_sq_cleanup() by using guard(mutex)() instead of
explicit mutex_lock() and mutex_unlock() calls. No functionality has
been changed.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Peter Wang <peter.wang@mediatek.com>
Link: https://patch.msgid.link/20251014200118.3390839-9-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Bart Van Assche
2025-10-14 13:01:00 -07:00
committed by Martin K. Petersen
parent 047f190494
commit bfe5f5dacf
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ufs/core/ufs-mcq.c
View File

@@ -568,12 +568,12 @@ int ufshcd_mcq_sq_cleanup(struct ufs_hba *hba, int task_tag)
id = hwq->id; id = hwq->id;
mutex_lock(&hwq->sq_mutex); guard(mutex)(&hwq->sq_mutex);
/* stop the SQ fetching before working on it */ /* stop the SQ fetching before working on it */
err = ufshcd_mcq_sq_stop(hba, hwq); err = ufshcd_mcq_sq_stop(hba, hwq);
if (err) if (err)
goto unlock; return err;
/* SQCTI = EXT_IID, IID, LUN, Task Tag */ /* SQCTI = EXT_IID, IID, LUN, Task Tag */
nexus = lrbp->lun << 8 | task_tag; nexus = lrbp->lun << 8 | task_tag;
@@ -600,8 +600,6 @@ int ufshcd_mcq_sq_cleanup(struct ufs_hba *hba, int task_tag)
if (ufshcd_mcq_sq_start(hba, hwq)) if (ufshcd_mcq_sq_start(hba, hwq))
err = -ETIMEDOUT; err = -ETIMEDOUT;
unlock:
mutex_unlock(&hwq->sq_mutex);
return err; return err;
} }