sugar/linux
1
0
Fork 0
Code Activity

soc: samsung: exynos-pmu: Annotate online/offline functions with __must_hold

Browse Source 
Annotate functions writing to PMU registers to online and offline CPUs
as __must_hold() the necessary spinlock for code correctness.  These are
static functions so possibility of mistakes is low here, but
__must_hold() serves as self-documenting code.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
Krzysztof Kozlowski
2025-09-05 19:37:18 +02:00
parent fe31e894c2
commit 3263127074
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/soc/samsung/exynos-pmu.c
View File

@@ -364,6 +364,7 @@ EXPORT_SYMBOL_GPL(exynos_get_pmu_regmap_by_phandle);
* disabled and cpupm_lock held. * disabled and cpupm_lock held.
*/ */
static int __gs101_cpu_pmu_online(unsigned int cpu) static int __gs101_cpu_pmu_online(unsigned int cpu)
__must_hold(&pmu_context->cpupm_lock)
{ {
unsigned int cpuhint = smp_processor_id(); unsigned int cpuhint = smp_processor_id();
u32 reg, mask; u32 reg, mask;
@@ -424,6 +425,7 @@ static int gs101_cpuhp_pmu_online(unsigned int cpu)
/* Common function shared by both CPU hot plug and CPUIdle */ /* Common function shared by both CPU hot plug and CPUIdle */
static int __gs101_cpu_pmu_offline(unsigned int cpu) static int __gs101_cpu_pmu_offline(unsigned int cpu)
__must_hold(&pmu_context->cpupm_lock)
{ {
unsigned int cpuhint = smp_processor_id(); unsigned int cpuhint = smp_processor_id();
u32 reg, mask; u32 reg, mask;