sugar/linux
1
0
Fork 0
Code Activity

rust: auxiliary: fix false positive warning for missing a safety comment

Browse Source 
Some older (yet supported) versions of clippy throw a false positive
warning for missing a safety comment when the safety comment is on a
multiline statement.

warning: unsafe block missing a safety comment
   --> rust/kernel/auxiliary.rs:351:22
    |
351 |                 Self(unsafe { NonNull::new_unchecked(adev) }),
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider adding a safety comment on the preceding line
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks
    = note: requested on the command line with `-W clippy::undocumented-unsafe-blocks`

warning: 1 warning emitted

Fix this by placing the safety comment right on top of the same line
introducing the unsafe block.

Fixes: e4e679c860 ("rust: auxiliary: unregister on parent device unbind")
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://patch.msgid.link/20251103203932.2361660-1-dakr@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
This commit is contained in:
Danilo Krummrich
2025-11-03 21:39:18 +01:00
parent f656279afd
commit 1bf5b90cd2
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
rust/kernel/auxiliary.rs
View File

@@ -341,13 +341,12 @@ impl Registration {
return Err(Error::from_errno(ret)); return Err(Error::from_errno(ret));
} }
// SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated
// successfully.
//
// INVARIANT: The device will remain registered until `auxiliary_device_delete()` is // INVARIANT: The device will remain registered until `auxiliary_device_delete()` is
// called, which happens in `Self::drop()`. // called, which happens in `Self::drop()`.
Ok(Devres::new( Ok(Devres::new(
parent, parent,
// SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated
// successfully.
Self(unsafe { NonNull::new_unchecked(adev) }), Self(unsafe { NonNull::new_unchecked(adev) }),
)) ))
}) })