From 1bf5b90cd2f984e5d6ff6fd30d5d85f9f579b6f0 Mon Sep 17 00:00:00 2001 From: Danilo Krummrich Date: Mon, 3 Nov 2025 21:39:18 +0100 Subject: [PATCH] rust: auxiliary: fix false positive warning for missing a safety comment Some older (yet supported) versions of clippy throw a false positive warning for missing a safety comment when the safety comment is on a multiline statement. warning: unsafe block missing a safety comment --> rust/kernel/auxiliary.rs:351:22 | 351 | Self(unsafe { NonNull::new_unchecked(adev) }), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: consider adding a safety comment on the preceding line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks = note: requested on the command line with `-W clippy::undocumented-unsafe-blocks` warning: 1 warning emitted Fix this by placing the safety comment right on top of the same line introducing the unsafe block. Fixes: e4e679c8608e ("rust: auxiliary: unregister on parent device unbind") Reviewed-by: Alice Ryhl Reviewed-by: Greg Kroah-Hartman Link: https://patch.msgid.link/20251103203932.2361660-1-dakr@kernel.org Signed-off-by: Danilo Krummrich --- rust/kernel/auxiliary.rs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/rust/kernel/auxiliary.rs b/rust/kernel/auxiliary.rs index cc67fa5ddde3..618eeeec2bd0 100644 --- a/rust/kernel/auxiliary.rs +++ b/rust/kernel/auxiliary.rs @@ -341,13 +341,12 @@ impl Registration { return Err(Error::from_errno(ret)); } - // SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated - // successfully. - // // INVARIANT: The device will remain registered until `auxiliary_device_delete()` is // called, which happens in `Self::drop()`. Ok(Devres::new( parent, + // SAFETY: `adev` is guaranteed to be non-null, since the `KBox` was allocated + // successfully. Self(unsafe { NonNull::new_unchecked(adev) }), )) })